Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MyFaronics.MyAnti-Virus version 4.31.3102.572 #55398

Closed
wants to merge 1 commit into from
Closed

MyFaronics.MyAnti-Virus version 4.31.3102.572 #55398

wants to merge 1 commit into from

Conversation

goreswapnil
Copy link

@goreswapnil goreswapnil commented Mar 23, 2022 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label Mar 23, 2022
@ghost
Copy link

ghost commented Mar 23, 2022

Hello @goreswapnil,
The pull request encountered an internal error and has been assigned to a developer to investigate.

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 23, 2022
@ghost ghost assigned JohnMcPMS and yao-msft Mar 23, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Internal-Error An unidentified error occurred in the validation pipeline Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 23, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label Mar 23, 2022
@ghost
Copy link

ghost commented Mar 23, 2022

Hello @goreswapnil,
The pull request encountered an internal error and has been assigned to a developer to investigate.

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 23, 2022
@ghost ghost assigned JohnMcPMS and yao-msft Mar 23, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Internal-Error An unidentified error occurred in the validation pipeline Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 23, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label Mar 23, 2022
@ghost
Copy link

ghost commented Mar 23, 2022

Hello @goreswapnil,
The pull request encountered an internal error and has been assigned to a developer to investigate.

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 23, 2022
@ghost ghost assigned JohnMcPMS Mar 23, 2022
@ghost ghost assigned yao-msft Mar 23, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Internal-Error An unidentified error occurred in the validation pipeline Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 23, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label Mar 23, 2022
@ghost
Copy link

ghost commented Mar 23, 2022

Hello @goreswapnil,
The pull request encountered an internal error and has been assigned to a developer to investigate.

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 23, 2022
@ghost ghost assigned JohnMcPMS and yao-msft Mar 23, 2022
ItzLevvie
ItzLevvie suggested changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's failing because the installer reboots the VM with 3010.

I tried /norestart but it doesn't work.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Mar 23, 2022
@JohnMcPMS
Copy link
Member

I don't really know how to read the MSI logs, but late in them, even with /norestart manually added, I see:

Property(S): REBOOT = Force

So I think that the MSI will always reboot. Given that I have created microsoft/winget-cli#2041 and this PR should probably be blocked on that feature. I don't really know if we can support automated validation with reboots though, but we should probably not treat it as an internal error if we can help it.

@JohnMcPMS JohnMcPMS added the Blocking-Issue Manifest validation is blocked by a known issue. label Mar 23, 2022
@goreswapnil goreswapnil deleted the autogenerated/MyFaronics.MyAnti-Virus/e9ac5b49-7bfa-4c2a-b313-a296148b9798 branch March 25, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie requested changes

Assignees

@JohnMcPMS JohnMcPMS

@yao-msft yao-msft

Labels
Blocking-Issue Manifest validation is blocked by a known issue. Internal-Error An unidentified error occurred in the validation pipeline Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@goreswapnil @wingetbot @JohnMcPMS @ItzLevvie @yao-msft