Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AdiIRC 3.9 #4692

Closed
wants to merge 1 commit into from
Closed

Added AdiIRC 3.9 #4692

wants to merge 1 commit into from

Conversation

rmarquis
Copy link
Contributor

@rmarquis rmarquis commented Nov 8, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Nov 8, 2020
@ghost ghost assigned denelon Nov 8, 2020
@ghost
Copy link

ghost commented Nov 8, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Installation-Error Error installing application label Nov 8, 2020
@ghost
Copy link

ghost commented Nov 8, 2020

rmarquis The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Nov 8, 2020
@KevinLaMS
Copy link
Contributor

image

@rmarquis
Copy link
Contributor Author

rmarquis commented Nov 9, 2020

Looks like another case of non zero success exit code: microsoft/winget-cli#137.
There is an existing PR to add support for this, but this hadn't been merged yet.

Nothing we can do but wait, I guess. The package still installs and works correctly.

@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs: Attention labels Nov 9, 2020
@ghost ghost closed this in #40772 Jan 14, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants