Swift.Toolchain 5.5.3 #46123

svanimpe · 2022-02-14T18:58:45Z

Have you signed the Contributor License Agreement?
Have you checked that there aren't other open pull requests for the same manifest update/change?
Have you validated your manifest locally with winget validate --manifest <path>?
Have you tested your manifest locally with winget install --manifest <path>?
Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

I've generated these using YamlCreate and the manifest version is 1.1.0 instead of 1.0. I assume that's OK?

Microsoft Reviewers: Open in CodeFlow

wingetbot · 2022-02-14T18:58:52Z

wingetbot · 2022-02-14T18:58:53Z

/AzurePipelines run

azure-pipelines · 2022-02-14T18:59:06Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2022-02-14T19:45:47Z

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost · 2022-02-14T19:45:50Z

@svanimpe,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

OfficialEsco

Ohhnooo this installer writes the wrong version to the registry 🤦‍♂️

Name        : Swift
Publisher   : dt.compnerd.org
Version     : 0.0.0.0
ProductCode : {51a6ef4e-285a-44fe-8f21-cdf5a6ee7245}
Uninstall   : winget uninstall --id "{51a6ef4e-285a-44fe-8f21-cdf5a6ee7245}"

Hmm, this is a Burn installer, would this be something one of you guys fix? @jedieaston @Trenly

OfficialEsco · 2022-02-15T08:13:50Z

manifests/s/Swift/Toolchain/5.5.3/Swift.Toolchain.installer.yaml

+# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.1.0.schema.json
+
+PackageIdentifier: Swift.Toolchain
+PackageVersion: 5.5.3


Suggested change

PackageVersion: 5.5.3

PackageVersion: 0.0.0.0

OfficialEsco · 2022-02-15T08:14:15Z

manifests/s/Swift/Toolchain/5.5.3/Swift.Toolchain.locale.en-US.yaml

+# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.1.0.schema.json
+
+PackageIdentifier: Swift.Toolchain
+PackageVersion: 5.5.3


Suggested change

PackageVersion: 5.5.3

PackageVersion: 0.0.0.0

OfficialEsco · 2022-02-15T08:14:26Z

manifests/s/Swift/Toolchain/5.5.3/Swift.Toolchain.yaml

+# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.1.0.schema.json
+
+PackageIdentifier: Swift.Toolchain
+PackageVersion: 5.5.3


Suggested change

PackageVersion: 5.5.3

PackageVersion: 0.0.0.0

May I ask what exactly this does? I assume it's a workaround, and not the value we actually want here?

Ah, or is this a version number exposed by the installer (I'm not the maintainer of this installer), as explained here: #28544 (comment)

jedieaston · 2022-02-15T14:01:58Z

Ohhnooo this installer writes the wrong version to the registry 🤦‍♂️
Name        : Swift
Publisher   : dt.compnerd.org
Version     : 0.0.0.0
ProductCode : {51a6ef4e-285a-44fe-8f21-cdf5a6ee7245}
Uninstall   : winget uninstall --id "{51a6ef4e-285a-44fe-8f21-cdf5a6ee7245}"
Hmm, this is a Burn installer, would this be something one of you guys fix? @jedieaston @Trenly

I looked into it last week. I spent like an hour trying to figure out how the heck the build scripts work but didn't get anywhere (it's like three repos, one of which is private so I can't see if they expose the version number to msbuild anywhere). If someone could drop something in the mailing list I bet they'd fix it.

svanimpe · 2022-02-18T18:18:58Z

If I may also ask for some advice: Am I following the correct procedure here for patch version upgrades? That is: Should I create them as new versions with new manifests? Or should I edit the existing 5.5 manifest to point to 5.5.3? I'm not sure how the updater works, so I figured it may be best to create a new manifest for each version.

OfficialEsco · 2022-02-18T18:34:34Z

If I may also ask for some advice: Am I following the correct procedure here for patch version upgrades? That is: Should I create them as new versions with new manifests? Or should I edit the existing 5.5 manifest to point to 5.5.3? I'm not sure how the updater works, so I figured it may be best to create a new manifest for each version.

You should create a new Manifest for each version yes, if it Auto updates you CAN delete and create a new manifest for the new version in the same PR (will be counted as Move and Modify as long as its in the same Software folder)

But we only do that for urls that don't contain versions like Spotify
Since we can't remember every software that auto updates its best to make a brand new manifest for urls with versions

denelon · 2022-02-18T20:06:02Z

It looks like we have 5.5 as the latest version in the repository currently. Unfortunately, without the package properly reporting the version to Windows Apps & Features, the Windows Package Manager would not be able to recognize this as an upgrade.

@OfficialEsco what are your thoughts about PRs like this where the package doesn't report the correct version, or doesn't report one at all? Should we block on the related issue below? It's the feature where the client begins to understand the "AppsAndFeatures" entry in the manifest.

What additional label would make sense in that case? "Version" or "Apps-and-Features"? or something like that?

Related to:

Improve package matching against Apps & Features Entry winget-cli#1952

OfficialEsco · 2022-02-18T20:15:15Z

Yeah that makes sense, DisplayVersion-Isssue might be clearer than Apps-and-Features as Apps-and-Features issues can be solved by ProductCodes

denelon · 2022-02-18T20:23:32Z

Sorry for the noise to come. I'm testing some additional automation.

ghost · 2022-02-18T20:24:00Z

svanimpe,

This package does not report a version in Windows Apps & Features, or it reports an incorrect version.

This PR is blocked until support for correlation between values in Windows Apps & Features is supported:

Improve package matching against Apps & Features Entry winget-cli#1952

ghost · 2022-02-18T20:24:42Z

@svanimpe,

This package does not report a version in Windows Apps & Features, or it reports an incorrect version.

This PR is blocked until support for correlation between values in Windows Apps & Features is supported:

Improve package matching against Apps & Features Entry winget-cli#1952

ItzLevvie

Is this PR still needed?

Developers of the Swift Toolchain have fixed their MSI version in latest releases: #57288

svanimpe · 2022-05-03T20:14:57Z

I was unaware this had been fixed. So yes, we can close this!

svanimpe added 2 commits February 14, 2022 19:51

Add Swift.Toolchain version 5.5.3

285bf86

Merge branch 'microsoft:master' into master

25b59d7

wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 14, 2022

OfficialEsco suggested changes Feb 15, 2022

View reviewed changes

ghost added the Needs-Author-Feedback This needs a response from the author. label Feb 15, 2022

ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 18, 2022

denelon removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Feb 18, 2022

denelon added Blocking-Issue Manifest validation is blocked by a known issue. Display-Version labels Feb 18, 2022

denelon added Display-Version and removed Display-Version labels Feb 18, 2022

ItzLevvie suggested changes May 3, 2022

View reviewed changes

ghost added the Needs-Author-Feedback This needs a response from the author. label May 3, 2022

svanimpe closed this May 3, 2022

ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 3, 2022

swift-ci mentioned this pull request Jul 17, 2024

[SR-15978] Outdated winget packages swiftlang/swift#58239

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swift.Toolchain 5.5.3 #46123

Swift.Toolchain 5.5.3 #46123

svanimpe commented Feb 14, 2022 •

edited by ghost

Loading

wingetbot commented Feb 14, 2022

wingetbot commented Feb 14, 2022

azure-pipelines bot commented Feb 14, 2022

ghost commented Feb 14, 2022

ghost commented Feb 14, 2022

OfficialEsco left a comment

OfficialEsco Feb 15, 2022

OfficialEsco Feb 15, 2022

OfficialEsco Feb 15, 2022

svanimpe Feb 18, 2022

svanimpe Feb 18, 2022

jedieaston commented Feb 15, 2022

svanimpe commented Feb 18, 2022

OfficialEsco commented Feb 18, 2022

denelon commented Feb 18, 2022

OfficialEsco commented Feb 18, 2022

denelon commented Feb 18, 2022

ghost commented Feb 18, 2022

ghost commented Feb 18, 2022

ItzLevvie left a comment

svanimpe commented May 3, 2022

Swift.Toolchain 5.5.3 #46123

Swift.Toolchain 5.5.3 #46123

Conversation

svanimpe commented Feb 14, 2022 • edited by ghost Loading

Microsoft Reviewers: Open in CodeFlow

wingetbot commented Feb 14, 2022

wingetbot commented Feb 14, 2022

azure-pipelines bot commented Feb 14, 2022

ghost commented Feb 14, 2022

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost commented Feb 14, 2022

OfficialEsco left a comment

Choose a reason for hiding this comment

OfficialEsco Feb 15, 2022

Choose a reason for hiding this comment

OfficialEsco Feb 15, 2022

Choose a reason for hiding this comment

OfficialEsco Feb 15, 2022

Choose a reason for hiding this comment

svanimpe Feb 18, 2022

Choose a reason for hiding this comment

svanimpe Feb 18, 2022

Choose a reason for hiding this comment

jedieaston commented Feb 15, 2022

svanimpe commented Feb 18, 2022

OfficialEsco commented Feb 18, 2022

denelon commented Feb 18, 2022

OfficialEsco commented Feb 18, 2022

denelon commented Feb 18, 2022

ghost commented Feb 18, 2022

ghost commented Feb 18, 2022

ItzLevvie left a comment

Choose a reason for hiding this comment

svanimpe commented May 3, 2022

svanimpe commented Feb 14, 2022 •

edited by ghost

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.