Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HERE OLPCLI version 10.0.36 #34021

Closed

Conversation

dmitriy-abramov
Copy link
Contributor

@dmitriy-abramov dmitriy-abramov commented Nov 4, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@ghost
Copy link

ghost commented Nov 4, 2021

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file extension should be .yaml instead of .yml to avoid the unkown file error.

This package also has a dependency on Java and won't be able to be added until microsoft/winget-cli#163 is finished
image

manifests/h/HERE/olp-cli/10.0.36/OLPCLI.yml Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 4, 2021
@ghost ghost removed Needs-Author-Feedback This needs a response from the author. Unexpected-File labels Nov 4, 2021
@ghost ghost removed the Unexpected-File label Nov 4, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 4, 2021
@ghost
Copy link

ghost commented Nov 4, 2021

Hello @dmitriy-abramov,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 4, 2021
@ghost ghost removed Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed labels Nov 4, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 5, 2021
@ghost ghost assigned dmitriy-abramov Nov 5, 2021
@ghost
Copy link

ghost commented Nov 5, 2021

Hello @dmitriy-abramov,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 5, 2021
@ghost ghost mentioned this pull request Nov 6, 2021
@ghost ghost closed this in #34173 Nov 6, 2021
@dmitriy-abramov dmitriy-abramov deleted the here-olp-cli branch April 20, 2022 14:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants