Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created manifest for Dell Command Monitor 10.6.0 #33989

Closed
wants to merge 1 commit into from

Conversation

prboyer
Copy link
Contributor

@prboyer prboyer commented Nov 4, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Submission containins materials of a third party: Dell Inc.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Nov 4, 2021
@ghost
Copy link

ghost commented Nov 4, 2021

Hello @prboyer,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 4, 2021
@Trenly
Copy link
Contributor

Trenly commented Nov 4, 2021

This package has a dependency that .NET Framework 4.6.1 or later is installed.
It may also have a dependency to only be run on dell hardware, which I couldn't test on my VM

@prboyer
Copy link
Contributor Author

prboyer commented Nov 5, 2021

@Trenly I believe both are true:

  • This package has a dependency that .NET Framework 4.6.1 or later is installed.
  • It has dependency to only be run on Dell hardware

Is there a way to specify either of these dependencies/requirements in the YAML manifest? I would imagine there has to be a way to link dependencies like .NET Framework 4.6.1.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 5, 2021
@Trenly
Copy link
Contributor

Trenly commented Nov 5, 2021

There are ways to mark the dependencies in the manifest. The 1.0.0 schema should be helpful for showing how to do this. I haven’t done it myself, but I believe it would be something like:

Dependencies:
  PackageDependencies:
  - PackageIdentifier: Microsoft.dotnet
     MinimumVersion: 4.6.1

However, the CLI currently doesn’t support automatic installation of dependencies; Its being tracked in microsoft/winget-cli#163 .

Custom hardware requirements are also not implemented yet, but are being tracked by #199504

Unfortunately, these block the PR from being validated until the CLI supports both dependencies and custom hardware

Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 6, 2021
@ghost ghost mentioned this pull request Nov 6, 2021
@ghost ghost closed this in #34173 Nov 6, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants