Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Byond 513.1529 #3267

Closed
wants to merge 2 commits into from
Closed

Add Byond 513.1529 #3267

wants to merge 2 commits into from

Conversation

ZeWaka
Copy link

@ZeWaka ZeWaka commented Aug 26, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Note: This program does not support a completely silent install, due to requiring administrator privileges to install. It will prompt with UAC.
Note: The program may produce an error code 1223. The program still installs successfully. This is due to some bug with the silent NSIS flag. If the flag is removed, it will no longer produce the error code.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 26, 2020
@ghost ghost assigned denelon Aug 26, 2020
@ghost
Copy link

ghost commented Aug 26, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation label Aug 27, 2020
@ghost ghost assigned KevinLaMS Aug 27, 2020
@ghost
Copy link

ghost commented Aug 27, 2020

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying [email protected] for investigation.

@ghost ghost added Needs SmartScreen Investigation and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Aug 27, 2020
@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application and removed Needs SmartScreen Investigation Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation labels Aug 29, 2020
@ghost
Copy link

ghost commented Aug 29, 2020

ZeWaka The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@KevinLaMS
Copy link
Contributor

I am seeing an error at the end of setup. I suspect this is by design and this is blocked on microsoft/winget-cli#137.

image

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Sep 5, 2020
@ghost
Copy link

ghost commented Sep 5, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this Sep 12, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants