Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BiglyBT #3202

Merged
4 commits merged into from
Aug 23, 2020
Merged

Add BiglyBT #3202

4 commits merged into from
Aug 23, 2020

Conversation

Witchilich
Copy link
Contributor

@Witchilich Witchilich commented Aug 22, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

I dont know when Install4J installer will be part of winget, so I made this manifest
microsoft/winget-cli#360
If you want to put custom location do not use one with spaces.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Aug 22, 2020
@ghost
Copy link

ghost commented Aug 22, 2020

Witchilich The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost added Needs: Attention and removed Needs: author feedback Manifest-Validation-Error Manifest validation failed labels Aug 22, 2020
@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 3202 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Needs: Attention label Aug 22, 2020
@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 3202 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 22, 2020
@ghost ghost assigned KevinLaMS Aug 22, 2020
@ghost
Copy link

ghost commented Aug 22, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Aug 23, 2020
@ghost
Copy link

ghost commented Aug 23, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 67177f5 into microsoft:master Aug 23, 2020
@Witchilich Witchilich deleted the patch-25 branch August 24, 2020 14:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants