Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TheScribusTeam.Scribus version 1.5.7 #31168

Closed
wants to merge 1 commit into from
Closed

TheScribusTeam.Scribus version 1.5.7 #31168

wants to merge 1 commit into from

Conversation

techflashYT
Copy link
Contributor

@techflashYT techflashYT commented Oct 23, 2021 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Unapproved-URL Needs-Attention This work item needs to be reviewed by a member of the core team. labels Oct 23, 2021
@ghost ghost assigned jamespik Oct 23, 2021
@techflashYT
Copy link
Contributor Author

huh? Unapproved URL? How is sourceforge (the only place you can get this from afaik), an unapproved URL?

ItzLevvie
ItzLevvie suggested changes Oct 24, 2021
View reviewed changes
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Validation-Unapproved-URL label: an engineer will take a look at it - possibly on Monday?

manifests/t/TheScribusTeam/Scribus/1.5.7/TheScribusTeam.Scribus.installer.yaml
Installers:
- Architecture: x64
InstallerType: nullsoft
InstallerUrl: https://newcontinuum.dl.sourceforge.net/project/scribus/scribus-devel/1.5.7/scribus-1.5.7-windows-x64.exe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InstallerUrl: https://newcontinuum.dl.sourceforge.net/project/scribus/scribus-devel/1.5.7/scribus-1.5.7-windows-x64.exe
InstallerUrl: https://sourceforge.net/projects/scribus/files/scribus-devel/1.5.7/scribus-1.5.7-windows-x64.exe/download

manifests/t/TheScribusTeam/Scribus/1.5.7/TheScribusTeam.Scribus.installer.yaml
InstallerSha256: E078145E379F1E1DC635A1B46F1495E7E8114B34009D3A6C619D10CB41A36D02
- Architecture: x86
InstallerType: nullsoft
InstallerUrl: https://cfhcable.dl.sourceforge.net/project/scribus/scribus-devel/1.5.7/scribus-1.5.7-windows.exe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InstallerUrl: https://cfhcable.dl.sourceforge.net/project/scribus/scribus-devel/1.5.7/scribus-1.5.7-windows.exe
InstallerUrl: https://sourceforge.net/projects/scribus/files/scribus-devel/1.5.7/scribus-1.5.7-windows.exe/download

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Oct 24, 2021
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Nov 3, 2021
@ghost
Copy link

ghost commented Nov 3, 2021

Hello @sanikdah,
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost mentioned this pull request Nov 6, 2021
Merged
@ghost ghost closed this in #34173 Nov 6, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie requested changes

Assignees

@jamespik jamespik

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Unapproved-URL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@techflashYT @wingetbot @ItzLevvie @jamespik