Malwarebytes.Malwarebytes version 4.4.6.232 #30069

GarethTheNerd · 2021-10-11T19:18:58Z

Have you signed the Contributor License Agreement?
Have you checked that there aren't other open pull requests for the same manifest update/change?
Have you validated your manifest locally with winget validate --manifest <path>?
Have you tested your manifest locally with winget install --manifest <path>?
Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

wingetbot · 2021-10-11T19:19:08Z

wingetbot · 2021-10-11T19:19:11Z

/AzurePipelines run

azure-pipelines · 2021-10-11T19:19:22Z

Azure Pipelines successfully started running 1 pipeline(s).

manifests/m/Malwarebytes/Malwarebytes/4.4.6.232/Malwarebytes.Malwarebytes.locale.en-US.yaml

…alwarebytes.locale.en-US.yaml Change version number Co-authored-by: Levvie - she/her <[email protected]>

wingetbot · 2021-10-12T10:27:51Z

/AzurePipelines run

azure-pipelines · 2021-10-12T10:28:01Z

Azure Pipelines successfully started running 1 pipeline(s).

ItzLevvie

You'll have to update the version folder as well, otherwise, the package will not pass pipelines.

ghost · 2021-10-12T10:30:10Z

Hello @GarethTheNerd,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

OfficialEsco · 2021-10-12T10:27:27Z

manifests/m/Malwarebytes/Malwarebytes/4.4.6.232/Malwarebytes.Malwarebytes.installer.yaml

+# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.0.0.schema.json
+
+PackageIdentifier: Malwarebytes.Malwarebytes
+PackageVersion: 4.4.6.232


Malwarebytes have some weird versioning so the url and ARP dosn't match

Suggested change

PackageVersion: 4.4.6.232

PackageVersion: 4.4.8.137

OfficialEsco · 2021-10-12T10:27:35Z

manifests/m/Malwarebytes/Malwarebytes/4.4.6.232/Malwarebytes.Malwarebytes.locale.en-US.yaml

+# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.0.0.schema.json
+
+PackageIdentifier: Malwarebytes.Malwarebytes
+PackageVersion: 4.4.6.232


Malwarebytes have some weird versioning so the url and ARP dosn't match

Suggested change

PackageVersion: 4.4.6.232

PackageVersion: 4.4.8.137

OfficialEsco · 2021-10-12T10:27:44Z

manifests/m/Malwarebytes/Malwarebytes/4.4.6.232/Malwarebytes.Malwarebytes.yaml

+# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.0.0.schema.json
+
+PackageIdentifier: Malwarebytes.Malwarebytes
+PackageVersion: 4.4.6.232


Malwarebytes have some weird versioning so the url and ARP dosn't match

Suggested change

PackageVersion: 4.4.6.232

PackageVersion: 4.4.8.137

OfficialEsco · 2021-10-12T10:28:37Z

manifests/m/Malwarebytes/Malwarebytes/4.4.6.232/Malwarebytes.Malwarebytes.installer.yaml

+  Architecture: x86
+  InstallerType: exe
+  Scope: machine
+  InstallerUrl: https://data-cdn.mbamupdates.com/web/mb4-setup-consumer/offline/mb4-setup-consumer-4.4.6.232-1.0.1474-1.0.45650.exe


We have had multiple issues with this link and i'm pretty sure i remember the previous installer getting removed once the new version is releases which is why we use the redirect url

Suggested change

InstallerUrl: https://data-cdn.mbamupdates.com/web/mb4-setup-consumer/offline/mb4-setup-consumer-4.4.6.232-1.0.1474-1.0.45650.exe

InstallerUrl: https://data-cdn.mbamupdates.com/web/mb4-setup-consumer/MBSetup.exe

Thanks. Those links fail to install for me on multiple machines. I believe that is the online installer. Not sure if the upgrade behaviour needs to be changed

I will look into it later 🙂

I thiiiiiiink i found a redirect url for the offline installer, but people reported issues on that one too..
This is the first time i've heard people have issues with the Online installer, would you mind posting a issue next time?

Currently the upgrade behavior is Install which runs the installer with the silent argument, the other upgrade behavior we can use is uninstallPrevious which uninstall the software then runs the installer with the silent argument, if Malwarebytes have a different upgrade switch you can add that under InstallerSwitches as Upgrade: <argument>

Ahh yeah this is the redirect link https://downloads.malwarebytes.com/file/mb4_offline to the offline installer

ItzLevvie

#30069 (comment)

You can set the PR in DRAFT mode until you've made changes to the package.

OfficialEsco · 2021-10-15T10:35:22Z

I've updated Malwarebytes to 4.4.8.137 so you can maybe test winget upgrade if you haven't updated yet? And report a problem if there is one.
If you find a better url you can just update the URL in the new manifest :)

Malwarebytes.Malwarebytes version 4.4.6.232

6213b9b

wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain Policy-Test-2.8 Needs-Attention This work item needs to be reviewed by a member of the core team. labels Oct 11, 2021

ghost assigned jamespik Oct 11, 2021

ItzLevvie suggested changes Oct 12, 2021

View reviewed changes

manifests/m/Malwarebytes/Malwarebytes/4.4.6.232/Malwarebytes.Malwarebytes.locale.en-US.yaml Outdated Show resolved Hide resolved

ghost added the Needs-Author-Feedback This needs a response from the author. label Oct 12, 2021

Update manifests/m/Malwarebytes/Malwarebytes/4.4.6.232/Malwarebytes.M…

5e89cc9

…alwarebytes.locale.en-US.yaml Change version number Co-authored-by: Levvie - she/her <[email protected]>

ItzLevvie suggested changes Oct 12, 2021

View reviewed changes

ghost added the Needs-Author-Feedback This needs a response from the author. label Oct 12, 2021

wingetbot added the Manifest-Validation-Error Manifest validation failed label Oct 12, 2021

OfficialEsco suggested changes Oct 12, 2021

View reviewed changes

ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 12, 2021

ChuckFerring-zz unassigned jamespik Oct 12, 2021

ItzLevvie suggested changes Oct 13, 2021

View reviewed changes

ghost added the Needs-Author-Feedback This needs a response from the author. label Oct 13, 2021

GarethTheNerd marked this pull request as draft October 13, 2021 09:04

ghost removed the Needs-Author-Feedback This needs a response from the author. label Oct 13, 2021

OfficialEsco mentioned this pull request Oct 13, 2021

New version: Malwarebytes.Malwarebytes version 4.4.8.137 #30197

Merged

5 tasks

ghost mentioned this pull request Nov 6, 2021

Remove Kebler.Kebler version 0.8.2.7 #34173

Merged

ghost closed this in #34173 Nov 6, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Malwarebytes.Malwarebytes version 4.4.6.232 #30069

Malwarebytes.Malwarebytes version 4.4.6.232 #30069

GarethTheNerd commented Oct 11, 2021 •

edited

Loading

wingetbot commented Oct 11, 2021

wingetbot commented Oct 11, 2021

azure-pipelines bot commented Oct 11, 2021

wingetbot commented Oct 12, 2021

azure-pipelines bot commented Oct 12, 2021

ItzLevvie left a comment

ghost commented Oct 12, 2021

OfficialEsco Oct 12, 2021

OfficialEsco Oct 12, 2021

OfficialEsco Oct 12, 2021

OfficialEsco Oct 12, 2021

GarethTheNerd Oct 12, 2021

GarethTheNerd Oct 12, 2021

OfficialEsco Oct 12, 2021

OfficialEsco Oct 12, 2021 •

edited

Loading

ItzLevvie left a comment

OfficialEsco commented Oct 15, 2021

	InstallerUrl: https://data-cdn.mbamupdates.com/web/mb4-setup-consumer/offline/mb4-setup-consumer-4.4.6.232-1.0.1474-1.0.45650.exe
	InstallerUrl: https://data-cdn.mbamupdates.com/web/mb4-setup-consumer/MBSetup.exe

Malwarebytes.Malwarebytes version 4.4.6.232 #30069

Malwarebytes.Malwarebytes version 4.4.6.232 #30069

Conversation

GarethTheNerd commented Oct 11, 2021 • edited Loading

Microsoft Reviewers: Open in CodeFlow

wingetbot commented Oct 11, 2021

wingetbot commented Oct 11, 2021

azure-pipelines bot commented Oct 11, 2021

wingetbot commented Oct 12, 2021

azure-pipelines bot commented Oct 12, 2021

ItzLevvie left a comment

Choose a reason for hiding this comment

ghost commented Oct 12, 2021

OfficialEsco Oct 12, 2021

Choose a reason for hiding this comment

OfficialEsco Oct 12, 2021

Choose a reason for hiding this comment

OfficialEsco Oct 12, 2021

Choose a reason for hiding this comment

OfficialEsco Oct 12, 2021

Choose a reason for hiding this comment

GarethTheNerd Oct 12, 2021

Choose a reason for hiding this comment

GarethTheNerd Oct 12, 2021

Choose a reason for hiding this comment

OfficialEsco Oct 12, 2021

Choose a reason for hiding this comment

OfficialEsco Oct 12, 2021 • edited Loading

Choose a reason for hiding this comment

ItzLevvie left a comment

Choose a reason for hiding this comment

OfficialEsco commented Oct 15, 2021

GarethTheNerd commented Oct 11, 2021 •

edited

Loading

OfficialEsco Oct 12, 2021 •

edited

Loading