Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE SCHEMA: nkdAgility.AzureDevOpsMigrationTools.16.0.9 to add ArchiveBinariesDependOnPath for Schema 1.9 #209263

Conversation

MrHinsh
Copy link
Contributor

@MrHinsh MrHinsh commented Jan 9, 2025

This change adds the necessary feature from microsoft/winget-cli#4816 to handle microsoft/winget-cli#2711 which we suffer from.

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


This change adds the necessary feature from microsoft/winget-cli#4816 to handle microsoft/winget-cli#2711 which we suffer from.


Microsoft Reviewers: Open in CodeFlow

This change adds the necessary feature from microsoft/winget-cli#4816 to handle microsoft/winget-cli#2711 which we suffer from.
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@MrHinsh MrHinsh changed the title Update: nkdAgility.AzureDevOpsMigrationTools.16.0.9 to add ArchiveBinariesDependOnPath for Schema 1.9 UPDATE SCHEMA: nkdAgility.AzureDevOpsMigrationTools.16.0.9 to add ArchiveBinariesDependOnPath for Schema 1.9 Jan 9, 2025
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 9, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 9, 2025
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires ManifestVersion: 1.9.0 to be applied to all .yaml files for 16.0.9

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jan 10, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Changes-Requested Changes Requested label Jan 10, 2025
@MrHinsh
Copy link
Contributor Author

MrHinsh commented Jan 10, 2025

This requires ManifestVersion: 1.9.0 to be applied to all .yaml files for 16.0.9

I have updates the other files! Sorry I missed them...

@wingetbot
Copy link
Collaborator

/AzurePipelines run

2 similar comments
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 10, 2025
@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 10, 2025
@wingetbot wingetbot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 11, 2025
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 11, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Jan 11, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 11, 2025
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 11, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 11, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit b19eeb3 into microsoft:master Jan 11, 2025
2 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants