Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evernote v6.25.0.9084 #2072

Closed
wants to merge 2 commits into from
Closed

Conversation

OfficialEsco
Copy link
Contributor

@OfficialEsco OfficialEsco commented Jun 24, 2020

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 24, 2020
@ghost ghost assigned denelon Jun 24, 2020
@ghost
Copy link

ghost commented Jun 24, 2020

This submission has moved to manual review.

@ghost
Copy link

ghost commented Jun 25, 2020

Greetings OfficialEsco
During installation testing, this application failed to install with out user input. Did you forget to add Silent or SilentWithProgress switches?

Please investigate a fix and resubmit the Pull Request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jun 25, 2020
In my testing /passive did indeed finish the installation just like /qn, but w/e
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 25, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

This submission has moved to manual review.

@OfficialEsco
Copy link
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2072 in repo microsoft/winget-pkgs

@OfficialEsco
Copy link
Contributor Author

Good to know

@KevinLaMS KevinLaMS added the Validation-Error General Error during testing. Requires we provide comment to author. label Jul 3, 2020
@ghost
Copy link

ghost commented Jul 3, 2020

OfficialEsco An issue was identified during the manual review, and the PR request cannot be approved. Please see comments for more information.
Please address the issue and resubmit, or if you disagree with this resolution, please raise an issue and flag this PR for further discussion.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jul 3, 2020
@KevinLaMS
Copy link
Contributor

Hey @OfficialEsco
When I run this, it seems to succeed, but the error returned from the installer is 3221225477. Do you know what this is and how we can get rid of it? The app seems to work fine despite that.

@OfficialEsco
Copy link
Contributor Author

@KevinLaMS i've just tested a few things and the already merged manifest, everything seems to return that error code, Evernote is also missing a icon while using WinGet

@ghost ghost removed the Needs: author feedback label Jul 3, 2020
@KevinLaMS
Copy link
Contributor

microsoft/winget-cli#137

@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 22, 2020
@OfficialEsco
Copy link
Contributor Author

This seems to have been fixed

@OfficialEsco OfficialEsco deleted the patch-8 branch April 4, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Validation-Error General Error during testing. Requires we provide comment to author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants