Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Nvidia.FrameView version 1.5 #195520

Conversation

lemonjacob
Copy link
Contributor

@lemonjacob lemonjacob commented Dec 1, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 1, 2024
@Dragon1573
Copy link
Contributor

Dragon1573 commented Dec 2, 2024

Hi @lemonjacob 👋🏼, glad to see you resolve the problem by yourself 👍🏼.

Could you please modify your very first comment as follows, in order to link this pull request to the issue? When the PR is merged, the issue will be automatically closed. This can prevent other users from confusing the issue state.

  Checklist for Pull Requests
  
  * [x]  Have you signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs)?
- * [x]  Is there a linked Issue? [[Package Request]: FrameView #195522](https://github.com/microsoft/winget-pkgs/issues/195522)
+ * [x]  Is there a linked Issue? Resolve #195522

@lemonjacob
Copy link
Contributor Author

Should have fixed it

Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @lemonjacob,

This package has a dependency on VCRedist:
image

auto-merge was automatically disabled December 2, 2024 22:27

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed New-Package labels Dec 2, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Dec 2, 2024
@stephengillie
Copy link
Collaborator

Verify with dependency:
image

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Dec 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 2, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Dec 2, 2024
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Dec 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 2, 2024
fixed manifest
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Dec 2, 2024
@lemonjacob
Copy link
Contributor Author

Should work now for some reason when I edited it on GitHub it would change the file when I committed changes. It worked when I used GitHub desktop instead of github.com

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit f0bae33 into microsoft:master Dec 3, 2024
2 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: FrameView
4 participants