-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version: TheDocumentFoundation.LibreOffice.LTS version 7.6.4 #138502
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @CoolPlayLin,
Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.) (Automated response - build 720) |
Hm, could this lead to issues, if two packages ( |
Hi @Trenly and @mdanish-kh, What are your thoughts on having duplicate installer details in 2 different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After committing the suggested changes, you would also have to rename the version folder to match the new PackageVersion. The folder under manifests/t/TheDocumentFoundation/LibreOffice/LTS
should be renamed from 7.6.4
-> 7.6.4.1
A quick and easy way to do this would be here in GitHub Web by pressing the . (dot) key on your keyboard that'll open up the PR in VS Code Online. Navigate to Explorer menu, find the required folder and make the appropriate rename changes.
After that, stage and commit your changes from Source Control menu on the left. (The changes are automatically pushed)
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.5.0.schema.json | ||
|
||
PackageIdentifier: TheDocumentFoundation.LibreOffice.LTS | ||
PackageVersion: 7.6.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackageVersion: 7.6.4 | |
PackageVersion: 7.6.4.1 |
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.5.0.schema.json | ||
|
||
PackageIdentifier: TheDocumentFoundation.LibreOffice.LTS | ||
PackageVersion: 7.6.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackageVersion: 7.6.4 | |
PackageVersion: 7.6.4.1 |
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.5.0.schema.json | ||
|
||
PackageIdentifier: TheDocumentFoundation.LibreOffice.LTS | ||
PackageVersion: 7.6.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackageVersion: 7.6.4 | |
PackageVersion: 7.6.4.1 |
If I'm understanding this correctly - |
Yes,
|
Ah yes, I believe that is going to be a side-effect of this change. Not sure what's more valuable - keeping existing users to get releases from the same "channel" they installed from, or correctly reflecting the status of each version in the repository. I'm inclining towards the second option, not the most ideal for existing users, but I think the actual solution would be implementation of proper channel support in winget: |
Hello @CoolPlayLin, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment. Template: msftbot/noRecentActivity |
Pull request was closed
Pull request was closed
@mdanish-kh Well, in the meantime 7.6.5 has been released. That version does not exist (and never existed) for the |
Microsoft Reviewers: Open in CodeFlow