Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WeChat #1336

Merged
2 commits merged into from
Jun 2, 2020
Merged

Fix WeChat #1336

2 commits merged into from
Jun 2, 2020

Conversation

SoftCreatR
Copy link
Contributor

@SoftCreatR SoftCreatR commented May 30, 2020 •
edited
Loading

n/t

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 30, 2020
@ghost ghost assigned denelon May 30, 2020
@ghost
Copy link

ghost commented May 30, 2020

This submission has moved to manual review.

@ChungZH
Copy link

ChungZH commented May 30, 2020

I just used WeChat when giving examples, please do not close my issue immediately. Thx

@KevinLaMS KevinLaMS added the Validation-Hash-Verification-Failed During manual testing, the Sha256 value no longer matches the installer. label Jun 2, 2020
@ghost
Copy link

ghost commented Jun 2, 2020

SoftCreatR I am sorry to report that the Sha256 Hash does not match the installer. This maybe caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jun 2, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot removed Needs: author feedback Validation-Hash-Verification-Failed During manual testing, the Sha256 value no longer matches the installer. labels Jun 2, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SoftCreatR
Copy link
Contributor Author

Okay, that's strange. When i created the fix, the Hash was different from what has been committed previously. As described in #848, the given hash WAS invalid and during my tests, the new hash worked.

Let's see, if it works now.

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 2, 2020
@ghost
Copy link

ghost commented Jun 2, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Jun 2, 2020
@ghost
Copy link

ghost commented Jun 2, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Jun 2, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 37d958a into microsoft:master Jun 2, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@denelon denelon

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SoftCreatR @wingetbot @ChungZH @KevinLaMS @denelon