Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Visual Studio 2019 Professional version 16.9.31112.23 to ID Microsoft.VisualStudio.2019.Professional. #13216

Conversation

jedieaston
Copy link
Contributor

@jedieaston jedieaston commented May 17, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


In order to prepare for Visual Studio 2022 coming this summer, I've moved all of the current Visual Studio manifests to be under a 2019 folder (so that we can support multiple major versions of Visual Studio). Please let me know if you disagree with how I've done this, but it is in line with how OpenJDK and Python have been reorganized.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 17, 2021
@ghost
Copy link

ghost commented May 17, 2021

@jedieaston The package manager bot determined that the metadata was not compliant.

As mentioned in this tweet, in winget-cli and winget-pkgs we have moved to the 1.0 format. Please update your manifest to the new format and submit again.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://github.com/microsoft/winget-cli/blob/master/doc/ManifestSpecv1.0.md)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Needs: author feedback label May 17, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed the Manifest-Validation-Error Manifest validation failed label May 17, 2021
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 17, 2021
@ghost
Copy link

ghost commented May 17, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit bfd7b9d into microsoft:master May 17, 2021
@jedieaston jedieaston deleted the Microsoft.VisualStudio.2019.Professional-16.9.31112.23-MOVE branch May 17, 2021 20:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants