Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JDownloader 2.0 #1247

Merged
3 commits merged into from
Apr 14, 2021
Merged

Add JDownloader 2.0 #1247

3 commits merged into from
Apr 14, 2021

Conversation

chausner
Copy link
Contributor

@chausner chausner commented May 27, 2020 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 27, 2020
@ghost ghost assigned denelon May 27, 2020
@ghost
Copy link

ghost commented May 27, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Installation-Error Error installing application label May 31, 2020
@ghost
Copy link

ghost commented May 31, 2020

chausner The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels May 31, 2020
@KevinLaMS
Copy link
Contributor

I am not sure why this installer seems to fail. It appears configured correctly. But i am getting "Installer Failed with exit code 1."

@chausner
Copy link
Contributor Author

chausner commented Jun 1, 2020

I am not sure why this installer seems to fail. It appears configured correctly. But i am getting "Installer Failed with exit code 1."

Hmm, it installs and runs fine for me when testing in Windows Sandbox.

@ghost ghost removed the Needs: author feedback label Jun 1, 2020
@KevinLaMS
Copy link
Contributor

Seems like this is the installer return value. Winget shows it as an error.
microsoft/winget-cli#137

@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 22, 2020
@ghost ghost removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application labels Apr 3, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Apr 3, 2021
@ghost ghost assigned KevinLaMS Apr 3, 2021
@ghost
Copy link

ghost commented Apr 3, 2021

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Apr 14, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Apr 14, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 908cdf6 into microsoft:master Apr 14, 2021
@chausner chausner deleted the jdownloader branch April 14, 2021 15:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@KevinLaMS KevinLaMS

@denelon denelon

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chausner @wingetbot @KevinLaMS @denelon