Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenRCT2 0.2.6 #1179

Merged
3 commits merged into from
May 13, 2021
Merged

Add OpenRCT2 0.2.6 #1179

3 commits merged into from
May 13, 2021

Conversation

latere-a-latere
Copy link
Contributor

@latere-a-latere latere-a-latere commented May 26, 2020 •
edited
Loading

This manifest installs correctly but for some reason the installer exits with code 1223. Does anybody know how to fix this?

Smartscreen result:

image

Part of latere-a-latere#4

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 26, 2020
@ghost ghost assigned denelon May 26, 2020
@ghost
Copy link

ghost commented May 26, 2020

This submission has moved to manual review.

@superusercode
Copy link
Contributor

@marnicgit smartscreen in edge no longer warns about openrct
image

@KevinLaMS KevinLaMS added the Validation-Installation-Error Error installing application label May 30, 2020
@ghost
Copy link

ghost commented May 30, 2020

MarNicGit The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels May 30, 2020
@KevinLaMS
Copy link
Contributor

Installer failed with exit code: 1223

@latere-a-latere
Copy link
Contributor Author

@KevinLaMS I am aware, that's why this PR is still a draft. Despite the error code the application runs fine and all the files are there it seems. Currently talking to OpenRCT2 to resolve this issue, once it's been figured out I'll be moving this PR from Draft to Ready for review.

@ghost ghost removed the Needs: author feedback label May 30, 2020
@latere-a-latere latere-a-latere changed the title Add OpenRCT 0.2.6 Add OpenRCT2 0.2.6 Jun 6, 2020
@latere-a-latere
Copy link
Contributor Author

@KevinLaMS Could you put the Blocking Issue label on this PR? It relates to microsoft/winget-cli#137.

@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 22, 2020
@KevinLaMS
Copy link
Contributor

microsoft/winget-cli#137

@denelon
Copy link
Contributor

denelon commented May 4, 2021

We now support non-zero success codes. If the manifest schema is updated, this might pass now 😄

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 11, 2021
@ghost
Copy link

ghost commented May 11, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@latere-a-latere
Copy link
Contributor Author

Commenting to prevent auto-closure, will provide a fix somewhere this week

@ghost ghost added Needs: Attention and removed Needs: author feedback No-Recent-Activity No activity has occurred on this work item for seven days. labels May 11, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 13, 2021
@ghost
Copy link

ghost commented May 13, 2021

@marnicgit The package manager bot determined that the metadata was not compliant.

As mentioned in this tweet, in winget-cli and winget-pkgs we have moved to the 1.0 format. Please update your manifest to the new format and submit again.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://github.com/microsoft/winget-cli/blob/master/doc/ManifestSpecv1.0.md)
For details on the error, see the details link below in the build pipeline.

@ghost ghost removed Needs: author feedback Manifest-Validation-Error Manifest validation failed Validation-Installation-Error Error installing application Blocking-Issue Manifest validation is blocked by a known issue. labels May 13, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@latere-a-latere latere-a-latere marked this pull request as ready for review May 13, 2021 21:46
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 13, 2021
@ghost
Copy link

ghost commented May 13, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes May 13, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit bf5031b into microsoft:master May 13, 2021
@latere-a-latere latere-a-latere deleted the OpenRCT2-0.2.6 branch May 13, 2021 21:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@denelon denelon

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@latere-a-latere @wingetbot @superusercode @KevinLaMS @denelon