Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifests/m/Microsoft/OpenJDK/17/17.0.4.8 #116006

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Update manifests/m/Microsoft/OpenJDK/17/17.0.4.8 #116006

merged 1 commit into from
Aug 10, 2023

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Aug 9, 2023 •
edited by microsoft-github-policy-service bot
Loading

cc @denelon

Microsoft Reviewers: codeflow:open?pullrequest=#116006

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Hash-Verification-Failed During manual testing, the Sha256 value no longer matches the installer. label Aug 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @Trenly,

I am sorry to report that the Sha256 Hash does not match the installer. This may be caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

Template: msftbot/validationError/installers/hashMismatch

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Aug 9, 2023
@Trenly
Copy link
Contributor Author

Trenly commented Aug 9, 2023

Not sure why the hash isn't matching. When I download it from the link, I get the hashes in the manifest

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Aug 9, 2023
@denelon
Copy link
Contributor

denelon commented Aug 9, 2023

/azp run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Validation-Hash-Verification-Failed During manual testing, the Sha256 value no longer matches the installer. label Aug 9, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Aug 9, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 9, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) August 9, 2023 23:36
@microsoft-github-policy-service
Copy link
Contributor

Trenly,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit a0afdcb into microsoft:master Aug 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello Trenly,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Trenly Trenly deleted the d355629b-be09-4c39-8d75-5b170bded782 branch August 15, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

Assignees

@Trenly Trenly

@AmelBawa-msft AmelBawa-msft

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trenly @wingetbot @denelon @stephengillie @AmelBawa-msft