Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anaconda.Anaconda3 version 2023.03-1 #109436

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Anaconda.Anaconda3 version 2023.03-1 #109436

merged 3 commits into from
Jun 13, 2023

Conversation

NJT145
Copy link
Contributor

@NJT145 NJT145 commented Jun 10, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: codeflow:open?pullrequest=#109436

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@NJT145 NJT145 marked this pull request as draft June 10, 2023 06:20
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Anaconda.Anaconda3 version 2023.03 version number changed to 2023.03-1
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NJT145 NJT145 changed the title Anaconda.Anaconda3 version 2023.03 Anaconda.Anaconda3 version 2023.03-1 Jun 10, 2023
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jun 10, 2023
@NJT145
Copy link
Contributor Author

NJT145 commented Jun 10, 2023

There is version 2023.03-0 and 2023.03-1. the version 2023.03-0 has a non-numeric version number. I mentioned that on this: ContinuumIO/anaconda-issues#13161. This pull request will sove the issue at #108663

@NJT145 NJT145 marked this pull request as ready for review June 10, 2023 06:34
@NJT145 NJT145 marked this pull request as draft June 10, 2023 06:35
@NJT145
Copy link
Contributor Author

NJT145 commented Jun 10, 2023

wingtcreate changed architecture type. I will update it with YamlCreate.ps1

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Manifest-Validation-Error Manifest validation failed label Jun 10, 2023
@NJT145 NJT145 marked this pull request as ready for review June 10, 2023 07:09
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jun 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @NJT145,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jun 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Jun 10, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jun 10, 2023
@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jun 12, 2023
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jun 12, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @NJT145,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jun 12, 2023
@NJT145
Copy link
Contributor Author

NJT145 commented Jun 12, 2023

I checked the installer exe with that code: (Get-Item .\Anaconda3-2023.03-1-Windows-x86_64.exe).VersionInfo | Format-List
And here what I found:

OriginalFilename  :
FileDescription   : Anaconda3 Installer
ProductName       : Anaconda3 2023.03-1 (64-bit)
Comments          : Created by constructor 3.4.3
CompanyName       : Anaconda, Inc.
FileName          : C:\Users\nejat\Downloads\Anaconda3-2023.03-1-Windows-x86_64.exe
FileVersion       : 2023.03-1
ProductVersion    : 2023.03-1
IsDebug           : False
IsPatched         : False
IsPreRelease      : False
IsPrivateBuild    : False
IsSpecialBuild    : False
Language          : İngilizce (Amerikan)
LegalCopyright    : (c) Anaconda, Inc.
LegalTrademarks   :
PrivateBuild      :
SpecialBuild      :
FileVersionRaw    : 2023.0.0.0
ProductVersionRaw : 2023.0.0.0

My system is tr-TR. "İngilizce (Amerikan)" means "English (American)".
The ProductName field is different than what I see in my system after download. The ProductName at my system is Anaconda3 2023.03-1 (Python 3.10.9 64-bit), and here what I get with winget list Anaconda.Anaconda3:

Name                                       Id                 Version   Available Source
----------------------------------------------------------------------------------------
Anaconda3 2023.03-1 (Python 3.10.9 64-bit) Anaconda.Anaconda3 2023.03-1 2023.03   winget

I guess the ProductName cause the problem at validation, don't know really.

@stephengillie stephengillie added Validation-Completed Validation passed and removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jun 12, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) June 12, 2023 22:39
@microsoft-github-policy-service
Copy link
Contributor

NJT145,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 4685261 into microsoft:master Jun 13, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello NJT145,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

1 similar comment
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@NJT145 NJT145 deleted the autogenerated/Anaconda.Anaconda3/1ab5581c-4f3e-4fc7-966b-b46c28c2f669 branch June 13, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants