Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrightSign.ProjectConverter version 1.0 #102150

Conversation

upintheairsheep
Copy link
Contributor

@upintheairsheep upintheairsheep commented Apr 11, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Apr 11, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @upintheairsheep,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@stephengillie
Copy link
Collaborator

Hi @upintheairsheep,

The installation isn't unattended:
image

Even with the .NET Framework preinstalled, this package prompts to install it. Is there an installer switch to bypass this and have it install automatically?

@microsoft-github-policy-service
Copy link
Contributor

Hello @upintheairsheep,

This package appears to require dependencies in order to install successfully.

This PR is blocked until support for dependencies is implemented in:

Template: msftbot/blockingIssue/dependencySupport

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Apr 11, 2023
@stephengillie
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Jan 2, 2024
@Trenly
Copy link
Contributor

Trenly commented Jan 2, 2024

Hi @upintheairsheep,

The installation isn't unattended: image

Even with the .NET Framework preinstalled, this package prompts to install it. Is there an installer switch to bypass this and have it install automatically?

Isn't 3.5 a Windows Feature (NetFx3) ?

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jan 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 2, 2024
@stephengillie stephengillie added WindowsFeatures Package needs a Windows Feature such as .NET Framework 3.5. and removed Dependencies labels Jan 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Jan 4, 2024
@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Mar 1, 2024
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Mar 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. labels Mar 1, 2024
Copy link
Contributor

Hello @upintheairsheep,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. WindowsFeatures Package needs a Windows Feature such as .NET Framework 3.5.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants