Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winget upgrade offers beta package version for stable package of Mozilla.Thunderbird #118246

Closed
fblz opened this issue Aug 25, 2023 · 4 comments · Fixed by #125335
Closed

winget upgrade offers beta package version for stable package of Mozilla.Thunderbird #118246

fblz opened this issue Aug 25, 2023 · 4 comments · Fixed by #125335
Labels
In-PR Resolution-Duplicate This issue or pull request already exists
Milestone

Comments

@fblz
Copy link

fblz commented Aug 25, 2023

Brief description of your issue

When I invoke winget upgrade it offers a Thunderbird Beta version as an upgrade for the stable version.

Steps to reproduce

This is from a fresh sandbox:

C:\Users\WDAGUtilityAccount>winget --version
v1.5.2201

C:\Users\WDAGUtilityAccount>winget install Mozilla.Thunderbird
The `msstore` source requires that you view the following agreements before using.
Terms of Transaction: https://aka.ms/microsoft-store-terms-of-transaction
The source requires the current machine's 2-letter geographic region to be sent to the backend service to function properly (ex. "US").

Do you agree to all the source agreements terms?
[Y] Yes  [N] No: y
Found Mozilla Thunderbird [Mozilla.Thunderbird] Version 115.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download-installer.cdn.mozilla.net/pub/thunderbird/releases/115.0/win64/en-US/Thunderbird%20Setup%20115.0.msi
  ██████████████████████████████  57.7 MB / 57.7 MB
Successfully verified installer hash
Starting package install...
Successfully installed

C:\Users\WDAGUtilityAccount>winget upgrade
Name                            Id                  Version     Available     Source
------------------------------------------------------------------------------------
Microsoft Edge                  Microsoft.Edge      92.0.902.67 116.0.1938.54 winget
Mozilla Thunderbird (x64 en-US) Mozilla.Thunderbird 115.0       117.0b6       winget
2 upgrades available.

Expected behavior

As I have installed Mozilla.Thunderbird and not Mozilla.Thunderbird.Beta, I would expect to not see 117.0b6 offered here.

Actual behavior

winget offers 117.0b6 of Mozilla.Thunderbird.Beta as an upgrade for Mozilla.Thunderbird.

Environment

C:\Users\WDAGUtilityAccount>winget --info
Windows Package Manager v1.5.2201
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19041.3324
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.2201.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Aug 25, 2023
@Trenly
Copy link
Contributor

Trenly commented Aug 26, 2023

@denelon denelon transferred this issue from microsoft/winget-cli Aug 28, 2023
@stephengillie stephengillie added Resolution-Duplicate This issue or pull request already exists and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Aug 28, 2023
@fblz
Copy link
Author

fblz commented Aug 28, 2023

I can't really understand why this issue was moved to winget-pkgs. If winget suggests a beta version as an upgrade for a stable version, I think the problem is not with winget-pkgs, but with the version detection of winget itself.

@Gorrrg
Copy link

Gorrrg commented Sep 8, 2023

I've also stumbled upon this issue and it basically makes it impossible to update Thunderbird via winget. If this is intentional why not remove the package completely?

@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
@treysis
Copy link
Contributor

treysis commented Nov 8, 2023

Issue is back.

treysis added a commit to treysis/winget-pkgs that referenced this issue Nov 8, 2023
Winget currently can't discriminate between normal versions and beta versions of Thunderbird. Until the version checking logic of winget is updated, beta versions have to be removed.
Fixes microsoft#118246
microsoft-github-policy-service bot pushed a commit that referenced this issue Nov 9, 2023
Winget currently can't discriminate between normal versions and beta versions of Thunderbird. Until the version checking logic of winget is updated, beta versions have to be removed.
Fixes #118246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Resolution-Duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants