Implement Group Policy

[florelis]

Implementing group policy. Interface is roughly based on ExperimentalFeatures and UserSettings.

This is still a draft. Still pending:

• E2E testing
• Better reporting and logging
• Use final registry keys/values from ADMX definition
• Implement policies for additional/allowed sources
• Showing policies enabled on winget --info

Related: #809 #154

Microsoft Reviewers: Open in CodeFlow

[github-actions]

Misspellings found, please review:

• declval
• Overriden
• POLICYMAPPING

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"usersettingstest validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"declval Overriden POLICYMAPPING "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

[JohnMcPMS]

    // Settings can be loaded from settings.json or settings.json.backup files.

If settings is disabled by policy, we should just quit before ever even loading a file. #Closed

---

Refers to: src/AppInstallerCommonCore/UserSettings.cpp:252 in b96cf8a. [](commit_id = b96cf8a, deletion_comment = False)

[github-actions]

Misspellings found, please review:

• declval
• POLICYMAPPING

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"usersettingstest validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"declval POLICYMAPPING "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

[florelis]

This is still missing E2E tests and the policies for controlling sources. I'll submit that as a separate PR as this one already got too big.

[JohnMcPMS]

THROW_HR_IF(E_INVALIDARG, !HasCompatibleType(T)); [](start = 12, length = 49)

nit (for now): Better to implement by calling TryGetValue and throwing when it returns nullopt to prevent future changes from needing to be made to both code paths.