-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Repository Lib #7
Conversation
@@ -0,0 +1,14 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file for? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual declaration of OSS in use. The automated system does not detect git dependencies well.
In reply to: 357321099 [](ancestors = 357321099)
bool Step(); | ||
|
||
// Gets the value of the specified column from the current row. | ||
// The index is 0 based. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What mad man would think otherwise? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,114 @@ | |||
// Copyright (c) Microsoft Corporation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) Microsoft Corp [](start = 3, length = 28)
Better to name the file SQLiteWrapperTests.cpp? #WontFix
@@ -31,6 +31,17 @@ steps: | |||
configuration: '$(buildConfiguration)' | |||
msbuildArgs: '/p:AppxBundlePlatforms="$(buildPlatform)" /p:AppxPackageDir="$(appxPackageDir)" /p:AppxBundle=Always /p:UapAppxPackageBuildMode=StoreUpload' | |||
|
|||
- task: CmdLine@2 | |||
inputs: | |||
script: 'RepositoryLibTests.exe -s -r junit -o TEST-RepositoryLib-$(_artifact).xml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RepositoryLibTests.exe [](start = 13, length = 22)
So for every new test project added, I need to update here? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this script would need to expand to include each test exe. While we could put them all together, I like the small rebuild size for individual ones.
In reply to: 357376907 [](ancestors = 357376907)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes
Adds a new static lib for holding code related to repositories. This initial checkin adds a simple C++ RAII wrapper around basic SQLite functionality. It also adds catch2 and a test exe project that will target the repository lib. A pair of simple tests are there to exercise basic SQLite functionality and flow.
As Component Governance cannot easily detect our use of catch2, an explicit reference is added via cgmanifest.json.
Tested
All of the public methods of the SQLite wrapper classes are exercised via the two tests.
The PR also adds some tasks to the pipeline to run the test and publish the results, failing the build if there are any failures.