Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WinGetUtilInterop project #4045

Merged
merged 9 commits into from
Jan 10, 2024
Merged

Conversation

msftrubengu
Copy link
Contributor

@msftrubengu msftrubengu commented Jan 9, 2024

This PR fulfills my lifelong dream of updating the WinGetUtilInterop to include most of the APIs from WinGetUtil. Internally we have a project with all this code, so I just copy them here with some minor changes. Because of that, some of them are not included. The idea would be that any new APIs added into WinGetUtil should have their corresponding C# interop implementation in the same PR.

APIs included:

  • WinGetLoggingInit
  • WinGetLoggingTerm
  • WinGetSQLiteIndexCreate
  • WinGetSQLiteIndexOpen
  • WinGetSQLiteIndexClose
  • WinGetSQLiteIndexAddManifest
  • WinGetSQLiteIndexUpdateManifest
  • WinGetSQLiteIndexRemoveManifest
  • WinGetSQLiteIndexPrepareForPackaging
  • WinGetSQLiteIndexCheckConsistency
  • WinGetCreateManifest
  • WinGetCloseManifest
  • WinGetValidateManifestV3
  • WinGetDownload
  • WinGetCompareVersions
  • WinGetBeginInstallerMetadataCollection
  • WinGetCompleteInstallerMetadataCollection

Missing ones:

  • WinGetValidateManifest
  • WinGetValidateManifestV2
  • WinGetValidateManifestDependencies
  • WinGetMergeInstallerMetadata

In that project we just have SQLite tests, so I port them too. I also added the same stylecops convention so you will see some header changes.

Microsoft Reviewers: Open in CodeFlow

@msftrubengu msftrubengu requested a review from a team as a code owner January 9, 2024 00:13

This comment has been minimized.

@msftrubengu msftrubengu merged commit b4d8c96 into microsoft:master Jan 10, 2024
8 checks passed
@msftrubengu msftrubengu deleted the wingetutil branch April 19, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants