Move to latest cppwinrt package across all projects #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
approved these changes
Nov 14, 2023
| @@ -160,24 +160,27 @@ namespace AppInstaller::Logging | |||
| } | |||
| } | |||
|
|
|||
| std::ostream& operator<<(std::ostream& out, const std::chrono::system_clock::time_point& time) | |||
| namespace std | |||
There was a problem hiding this comment.
Adding to the std namespace seems weird
There was a problem hiding this comment.
I don't know what properties the latest C++/WinRT is forcing on us, but they ended up breaking most of these operator<< overloads that were in the global namespace. Leveraging ADL to overcome this requires putting these into std (or std::chrono here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Move all projects that use C++/WinRT, WIL, and C#/WinRT to the latest release. Then fix all of the build breaks that this caused.
This also re-enables a test that needed a newer version of C++/WinRT to work.
After many attempts to debug the issue with the tests that crash on x64 only, I can only assume that there is some perfect collection of OS and dependency versions that will hopefully change at some point and allow us to re-enable them. I have tried so many attempts at debugging it and ran it on a similar server VM to no avail. Given that it is only affecting the inproc tests in x64, I can only assume that it something in codegen somewhere. Will have to try to enable them later.
Validation
Local build and unit tests succeeded; PR regression tests should cover the rest.
Microsoft Reviewers: Open in CodeFlow