Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.WinGet.Configuration messages #3242

Merged
merged 11 commits into from
May 18, 2023

Conversation

msftrubengu
Copy link
Contributor

@msftrubengu msftrubengu commented May 11, 2023

This PR starts printing information messages for Get-WingetConfiguration and Get-WingetConfigurationDetails. The messages are similar to what winget is showing.

Also:

  • Add resource file with necessary configuration messages. These are mostly the same as the one winget uses.
  • Modify AsyncCommand to always use a BlockingCollection for storing messages. The messages are written to PowerShell when a cmdlet waits for the task to complete or a Complete-* cmdlet executes and the task is already completed. This completely removes the context switch (which might come back if we ever require a ShouldContinue/ShouldProgress in the middle of the task)

Next:

  • Finish apply cmdlets messages
  • add formats file for output objects
Microsoft Reviewers: Open in CodeFlow

@msftrubengu msftrubengu requested a review from a team as a code owner May 11, 2023 05:03
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@msftrubengu msftrubengu merged commit d68357d into microsoft:master May 18, 2023
@msftrubengu msftrubengu deleted the pwshmessages branch August 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants