Queue write operations for Start-* cmdlets and hook up diagnostics #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
approved these changes
May 5, 2023
src/PowerShell/Microsoft.WinGet.Configuration.Cmdlets/Cmdlets/GetWinGetConfigurationCmdlet.cs
Outdated
Show resolved
Hide resolved
msftrubengu
changed the title
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
approved these changes
May 8, 2023
| (boolStr[3] == 's' || boolStr[3] == 'S') && | ||
| (boolStr[4] == 'e' || boolStr[4] == 'E')) | ||
| { | ||
| return true; |
There was a problem hiding this comment.
I don't see the value in explicitly checking for 0/NO/FALSE when the default return value is the same.
src/PowerShell/Microsoft.WinGet.Configuration.Engine/PSObjects/PSConfigurationProcessor.cs
Show resolved
Hide resolved
JohnMcPMS
reviewed
May 8, 2023
src/PowerShell/Microsoft.WinGet.Configuration.Engine/PSObjects/PSConfigurationProcessor.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Start-* cmdlet starts its operation it won't write to any PowerShell stream because control is returned back to the user almost immediately. This changes queue messages to be then displayed at Continue-* time. This way, we will have all the messages in the appropriate order. It applies for WriteDebug, WriteVerbose, WriteWarning, WriteError and WriteProgress.
WriteProgress will only be called when the activity hasn't been completed. A caller must use
AsyncCommand.GetNewProgressActivityIdto generate a new activity id.Microsoft Reviewers: Open in CodeFlow