Fix tags for --count argument #3195
Conversation
microsoft-github-policy-service
bot
added
the
Issue-Bug
| @@ -48,7 +48,7 @@ namespace AppInstaller::CLI | |||
| case Execution::Args::Type::Source: | |||
| return { type, "source"_liv, 's', ArgTypeCategory::Source }; | |||
| case Execution::Args::Type::Count: | |||
| return { type, "count"_liv, 'n', ArgTypeCategory::MultiplePackages }; | |||
| return { type, "count"_liv, 'n', ArgTypeCategory::PackageQuery | ArgTypeCategory::SinglePackageQuery }; | |||
There was a problem hiding this comment.
I don't see how MultiplePackages is incorrect from an English semantics standpoint (I'm not sure how it differs from PackageQuery either though, which itself seems like an issue).
This feels like it is masking the actual issue since there is no way that count applies to SinglePackageQuery. I don't think we are interested in providing an "I'm feeling lucky" experience.
From looking more into the ArgTypeCategory design, what is needed is to make Args::Type::Query into Args::Type::QueryForSingle and Args::Type::QueryForMany (as example names). This will allow for different categories to match the different semantics for the commands.
There was a problem hiding this comment.
Although I suppose we haven't done what I suggested for the name, etc. so maybe we don't want to do that for now.
There was a problem hiding this comment.
This was related to a previous feature to support installing multiple packages with 1 command invocation.
winget install TestApp1 TestApp2 is categorized as Multiple
winget install TestApp1 is categorized as SinglePackageQuery
The naming may seem a bit confusing with the concept of querying for single/multiple package
This fixes the tags on the --count argument, which were causing an error during arg validation when it was used.
Closes #3194
Microsoft Reviewers: Open in CodeFlow