Fix PSInstalledCatalogPackage being piped to Upgrade-WinGetPackage #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryfu-msft
reviewed
Apr 25, 2023
src/PowerShell/Microsoft.WinGet.Client.Engine/PSObjects/PSInstalledCatalogPackage.cs
Outdated
Show resolved
Hide resolved
ryfu-msft
approved these changes
Apr 25, 2023
…alledCatalogPackage.cs Co-authored-by: Ryan <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Update-WinGetPackage, the pipeline can set thePSCatalogPackagecan be set by value or property name and theVersionby property name.The result of
Get-WinGetPackagepiped toUpdate-WinGetPackageresults in both properties being set. In this case, the version is not the desired version to update but the installed version. Internally, when we iterate through all the available versions of the catalog package object we will throw InvalidVersionException because well the version is not available...To fix it, I renamed the
Versionproperty of thePSInstalledCatalogPackagetoInstalledVersionto mimic what the underlying catalog package property actually is. This way the version will not be piped intoUpdate-WinGetPackagebut the caller can also specify which one it wants to update giving a better experience.Microsoft Reviewers: Open in CodeFlow