Add support for bool, strings and arrays in Configuration settings #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
requested changes
Apr 6, 2023
src/Microsoft.Management.Configuration.Processor/Extensions/ValueSetExtensions.cs
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
requested changes
Apr 7, 2023
| arrayValues.end(), | ||
| [](const IKeyValuePair<winrt::hstring, winrt::Windows::Foundation::IInspectable>& a, const IKeyValuePair<winrt::hstring, winrt::Windows::Foundation::IInspectable>& b) | ||
| { | ||
| return a.Key() < b.Key(); |
There was a problem hiding this comment.
These keys are strings and won't sort numerically.
| { | ||
| if (input.empty()) | ||
| { | ||
| return {}; |
There was a problem hiding this comment.
This returns an empty optional, which isn't what I would expect. It should return an optional with an empty string in it.
| template <typename T> | ||
| std::optional<T> try_as() const | ||
| { | ||
| Require(Type::Scalar); |
There was a problem hiding this comment.
This will throw if the node isn't a scalar. Should it just return an empty optional instead?
src/AppInstallerSharedLib/Yaml.cpp
Outdated
| // Avoid THROW_HR to don't log. | ||
| if (Utility::CaseInsensitiveEquals(m_scalar, "true") || | ||
| Utility::CaseInsensitiveEquals(m_scalar, "false")) | ||
| else |
There was a problem hiding this comment.
I would continue to use the early return pattern rather than an else.
| { | ||
| return true; | ||
| return std::optional{ static_cast<int>(std::stoll(m_scalar, 0, 0)) }; |
There was a problem hiding this comment.
Suggested change
| return std::optional{ static_cast<int>(std::stoll(m_scalar, 0, 0)) }; | |
| return std::optional{ static_cast<int>(std::stol(m_scalar, 0, 0)) }; |
| { | ||
| if (!valueSet.ContainsKey(TreatAsArray)) | ||
| { | ||
| throw new InvalidOperationException(); | ||
| } | ||
|
|
||
| var result = new List<object>(); | ||
| var sortedList = new SortedList<string, object>(); |
There was a problem hiding this comment.
string sort won't work once we hit 11 items.
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JohnMcPMS
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow