Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove blank line #2906

Merged
merged 1 commit into from
Feb 2, 2023
Merged

chore: remove blank line #2906

merged 1 commit into from
Feb 2, 2023

Conversation

wdhdev
Copy link

@wdhdev wdhdev commented Feb 2, 2023


Microsoft Reviewers: Open in CodeFlow

@wdhdev wdhdev requested a review from a team as a code owner February 2, 2023 05:49
@yao-msft
Copy link
Contributor

yao-msft commented Feb 2, 2023

I saw multiple prs created for making code clean (i.e. removing space, empty line, re-wording, etc).
Though I let this pr through, I believe we'd prefer all such changes in 1 pr so we could have a short and clean commit history.

@yao-msft yao-msft merged commit 53e83b2 into microsoft:master Feb 2, 2023
@wdhdev wdhdev deleted the patch-3 branch February 2, 2023 22:39
@wdhdev
Copy link
Author

wdhdev commented Feb 2, 2023

I saw multiple prs created for making code clean (i.e. removing space, empty line, re-wording, etc).
Though I let this pr through, I believe we'd prefer all such changes in 1 pr so we could have a short and clean commit history.

I will make sure to do this in the future. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants