-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Enabled Admin Settings in --info #2901
Conversation
@denelon, does this align with what you visioned for showing admin settings? Basically this is showing a list of enabled admin settings, those not enabled were not shown. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I was actually thinking about whether it makes sense to show all of them and their state. Group policy objects are either "Enabled", "Disabled", or "Not Configured". I don't know that it makes sense to display them all or not. It could be inconsistent to not display the ones that aren't configured, but their states is a tuple so maybe it's OK.
|
It's a small change to show all of them. Can have it done in ~5 minutes. My thought was that group policies are only shown if they are present and configured. There are more than 2 group policies available, but since only 2 are configured, they are the only ones shown in the list. For Admin settings they are always present and configured (default to false); It could become a very cluttered output if they were all shown. I could see, perhaps, a middle ground where they are hidden by default, but if any one of them is enabled then show all of them with state. @denelon - Just need a decision on what you think is best UX
|
Had a sync with denelon separately, and updated per his comments |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -67,15 +67,15 @@ namespace AppInstaller::CLI | |||
auto info = context.Reporter.Info(); | |||
info << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I guess this could be removed too with the latest change
winget --info
#2898This is only a partial implementation, as the user settings are much more complicated. The table is only output if there are AdminSettings enabled, and only shows the admin settings that are enabled