Refactor test workflow source search #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another refactor that nobody asked for, for something that has been bothering me for a long time and I couldn't ignore while working on something else... (I swear I am also working on the stuff I'm supposed to!)
This change breaks up the huge
WorkflowTestCompositeSource::Search()function, which was a long series of "if query is 'package' then add package to search results" (and which had a fun compilation warning about using too much space in the stack). I'm doing this by creating objects containing the matching query string and the modifications made to the search results in case of a match. Then, the search function can just iterate over these objects and modify the results when appropriate.On each test, we now declare which results we want to get and we can use the query strings from these objects instead of duplicating the strings on each place they are needed.
I couldn't come up with a good name for these objects, so I'm expecting feedback on that if this change is something we want.
Microsoft Reviewers: Open in CodeFlow