-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement WinGetUserSettings cmdlets #2776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
reviewed
Dec 27, 2022
src/PowerShell/Microsoft.WinGet.Client/Commands/GetUserSettingsCommand.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements 3 cmdlets:
The settings file is read via
winget settings export
, so these commands require a newer version of winget. In the near future, I'll add a new attribute in each cmdlet that specify the minimum winget version that is required.To be testable, the cmdlets follow the similar patter to pick which version of winget to use via USE_PROD_CLSIDS. I'll change the name to something more general in a future PR. We also need to modify the crescendo generated functions to point to wingetdev without it being that intrusive.
I also tried to move the PowerShell E2E to use PowerShell host to make better tests, but I got some issues and I kind of gave up for now to keep the code flowing. The user settings cmdlets tests use PowerShell host though. However, the Microsoft.WinGet.Client project cannot be references by AppInstallerCLIE2ETests because PowerShell host will complain while trying to load the module. My guess is that there's some conflict loading the Microsoft.WinGet.Client.dll
Also, made more general improvements to Microsoft.WinGet.Client.
Related to #2697
Microsoft Reviewers: Open in CodeFlow