Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean build from winget-cli #2698

Merged
merged 6 commits into from
Nov 23, 2022
Merged

Clean build from winget-cli #2698

merged 6 commits into from
Nov 23, 2022

Conversation

msftrubengu
Copy link
Contributor

@msftrubengu msftrubengu commented Nov 14, 2022 •
edited by ghost
Loading

This PR allows winget-cli to be built cleanly from a new machine by importing the .vsconfig into their Visual Studio Edition

  • Update .vsconfig to remove/add components.
  • Add missing dependency of AppInstallerTestExeInstaller in AppInstallerCLITests
  • Move AppInstallerCLITests to the top of the solution file to automatically be the first one selected on Visual Studio.
  • Add nuget.config for public dependencies.

To fully build winget-cli Microsoft Visual Studio Installer vsix is still required.

Microsoft Reviewers: Open in CodeFlow

@msftrubengu msftrubengu requested a review from a team as a code owner November 14, 2022 21:58
yao-msft
yao-msft reviewed Nov 14, 2022
View reviewed changes
.vsconfig Outdated Show resolved Hide resolved
@yao-msft
Copy link
Contributor

Binskim task behavior changed, we'll need to pull in this pr after it's merged for the build fix #2704

@msftrubengu msftrubengu merged commit bb0d360 into microsoft:master Nov 23, 2022
gitwitdaprogramz pushed a commit to gitwitdaprogramz/winget-cli that referenced this pull request Nov 26, 2022
@msftrubengu @gitwitdaprogramz
Clean build from winget-cli (microsoft#2698)
6da7133 
* Build clean from a fresh VM

* Make AppInstallerCLIPackage default

* Remove 19041 and update AppIntallerCaller

* PR comments and add include
@msftrubengu msftrubengu deleted the cleanbuild branch November 28, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco273637288 marco273637288 marco273637288 left review comments

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msftrubengu @yao-msft @marco273637288