Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate SignatureSha256 for MSIX packages during the manifest validation #2384

Merged
merged 8 commits into from
Jul 28, 2022
Merged

Validate SignatureSha256 for MSIX packages during the manifest validation #2384

merged 8 commits into from
Jul 28, 2022

Conversation

AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Jul 27, 2022 •
edited by ghost
Loading

What was done?

  • Added validation for SignatureSha256 in the manifest validation code.
  • Promoted all MSIX manifest validation code to a separate class.
  • Updated existing MSIX manifest validation unit test code.

Test

  • Ensured existing AppInstallerCLITests are successful.
  • Covered MSIX manifest validation for all combination of signed/unsigned msix/msixbundle packages.
Microsoft Reviewers: Open in CodeFlow

@AmelBawa-msft AmelBawa-msft marked this pull request as ready for review July 27, 2022 20:52
@AmelBawa-msft AmelBawa-msft requested a review from a team as a code owner July 27, 2022 20:52
@AmelBawa-msft AmelBawa-msft merged commit e8f5c43 into microsoft:master Jul 28, 2022
@AmelBawa-msft AmelBawa-msft deleted the hash-validation branch July 28, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmelBawa-msft @JohnMcPMS