Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in correlation test script #2206

Merged
merged 5 commits into from
May 31, 2022

Conversation

florelis
Copy link
Member

@florelis florelis commented May 31, 2022

This contains two changes to improve the error handling in the correlation test script:

  1. In case we are using the dev package, when installing the VCLibs dependency, fall back to downloading it if it is not present in the SDK folder. This allows running the script from a machine that doesn't have dev dependencies by simply copying the dev package folder there.
  2. Add a timeout for the install operation on the correlation program to ensure the results JSON is generated with the appropriate message, instead of being empty due to the driver script killing the sandbox. This ensures timeouts are reported in the failed.json when processing the results.
Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner May 31, 2022 21:16
@florelis florelis merged commit 3f4645a into microsoft:master May 31, 2022
@florelis florelis deleted the correlationTestBed branch May 31, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants