Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat manifest localization validation error as warning for non full validation(manifest reading) #2144

Merged
merged 1 commit into from
May 9, 2022

Conversation

yao-msft
Copy link
Contributor

@yao-msft yao-msft commented May 6, 2022

Added tests.

Microsoft Reviewers: Open in CodeFlow

@yao-msft yao-msft requested a review from a team as a code owner May 6, 2022 20:26
Copy link
Member

@JohnMcPMS JohnMcPMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also have tests in place that show that Invalid is still a "valid" option? For instance, if there is only one installer set to neutral, would it be chosen or would it be inapplicable?

@yao-msft
Copy link
Contributor Author

yao-msft commented May 9, 2022

Do we also have tests in place that show that Invalid is still a "valid" option? For instance, if there is only one installer set to neutral, would it be chosen or would it be inapplicable?

Currently, for rest source, if the bad data is found in Installers, we'll treat the rest response as invalid. It won't go far enough to installer selection step.

@yao-msft yao-msft merged commit 55bf254 into microsoft:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants