Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exceptions breaking out of the multi-package install loop #2089

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Fix exceptions breaking out of the multi-package install loop #2089

merged 1 commit into from
Apr 12, 2022

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Apr 12, 2022 •
edited by ghost
Loading

Fixes #1442

Change

Wrap the subexecution with a try/catch to prevent exceptions from breaking out of the mult-package install loop.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner April 12, 2022 21:37
@ghost ghost added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Apr 12, 2022
@JohnMcPMS JohnMcPMS merged commit 8340ee2 into microsoft:master Apr 12, 2022
@JohnMcPMS JohnMcPMS deleted the catch-exceptions-multi branch April 12, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

winget upgrade --all fails for all packages even if only one single package causes error
2 participants
@JohnMcPMS @yao-msft