-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prompts when installer aborts terminal or needs install location #1814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments on the default install root setting also apply to the install location argument on a multipackage install. I'm just not sure it makes sense to have one location apply to multiple packages.
This comment was marked as outdated.
This comment was marked as outdated.
Note that this is still missing tests, validation of the install root and the arg/setting to disable prompts. (Hence still a draft) I had thought of moving installers that abort the terminal to the end so as to minimize their impact, but that seems tricky with dependencies. |
Reviving this old PR... Main changes from last time:
|
# Conflicts: # src/AppInstallerCLICore/ExecutionArgs.h # src/AppInstallerCLIE2ETests/Constants.cs # src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw # src/AppInstallerCommonCore/Public/AppInstallerErrors.h # src/AppInstallerCommonCore/Public/winget/UserSettings.h # src/AppInstallerCommonCore/UserSettings.cpp
# Conflicts: # src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw
This PR is having issues with the COM InProc E2E tests because I added something that causes us to load the string resources in a place we weren't doing it before, and the tests fail there because they cannot find the resources. I still don't know how to fix it (and it would make this change bigger), so I'm sidestepping it for now by preventing this new use of the ResourceLoader. I'll open an issue for actually fixing it because I imagine it will hit us again later. |
Resolves: #713
Resolves: #970
Changes:
InstallerAbortsTerminal
(to confirm that we want to install) orInstallLocationRequired
(to provide the install location).Remaining items:
Microsoft Reviewers: Open in CodeFlow