Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some build warnings #1794

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Fix some build warnings #1794

merged 1 commit into from
Dec 13, 2021

Conversation

florelis
Copy link
Member

@florelis florelis commented Dec 13, 2021 •
edited by ghost
Loading

  • Updated dependency of WingetUtilInterop.UnitTests on Microsoft.Msix.Utils to version 2.0.3. The version previously used (1.0.*) targeted .NET Framework and caused a build warning as that project uses .NET Core. Updated version targets .NET Standard and does cause the same warning.
  • Fixed outstanding spellchecking warning about "archs".
  • Rearranged some items in the tests' project file to follow alphabetical order, and moved the multifile manifest v1_1 test data to its own filter.
Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner December 13, 2021 22:27
msftrubengu
msftrubengu approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@msftrubengu msftrubengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@florelis florelis merged commit 2a749eb into microsoft:master Dec 13, 2021
@florelis florelis deleted the warnings branch December 13, 2021 23:35
Sandesh333333
Sandesh333333 reviewed Jan 17, 2022
View reviewed changes
Copy link

@Sandesh333333 Sandesh333333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sandesh petkar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandesh333333 Sandesh333333 Sandesh333333 left review comments

@msftrubengu msftrubengu msftrubengu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florelis @msftrubengu @Sandesh333333