Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source agreement market message to be more clear #1731

Merged
merged 3 commits into from
Nov 20, 2021

Conversation

yao-msft
Copy link
Contributor

@yao-msft yao-msft commented Nov 19, 2021

There's been feedback item filed claiming the source agreement market message is not clear enough so making explicit that we are sending the geographic region info to the source's backend server.

Microsoft Reviewers: Open in CodeFlow

@yao-msft yao-msft requested a review from a team as a code owner November 19, 2021 23:36
Co-authored-by: JohnMcPMS <[email protected]>
Copy link
Member

@JohnMcPMS JohnMcPMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that can be linked against? I'm good with this but I was hoping that whomever raised the issue could also approve it. If it was only feedback, then I guess we just have to hope this is satisfactory.

@yao-msft
Copy link
Contributor Author

It's feedback item, not a github issue.

@yao-msft yao-msft merged commit 73d35a2 into microsoft:master Nov 20, 2021
@yao-msft yao-msft deleted the updatemarketmsg branch November 20, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants