Prevent circular dependency in global telemetry logger creation #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
requested changes
Nov 4, 2021
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
JohnMcPMS
approved these changes
Nov 9, 2021
| thread_local std::once_flag initLogging; | ||
|
|
||
| std::call_once(initLogging, []() { | ||
| std::unique_ptr<AppInstaller::ThreadLocalStorage::PreviousThreadGlobals> previous = threadGlobals.SetForCurrentThread(); |
There was a problem hiding this comment.
While this may solve the problem when the code stays on one thread, it may make other problems that we are not aware of. I would rather we fix it completely by creating a set of APIs that give more explicit control over the thread globals so that callers can actually control what is happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a potential circular dependency between the telemetry object and the logger object due to the need to open settings to finish telemetry construction.
Microsoft Reviewers: Open in CodeFlow