Rearrange choices for ARP changes #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Rearrange the way that we choose which ARP entry is the one to log. Real world data has shown that users often install the same version of the package, so this change leans more towards choosing a matching entry then a changed one. Given that our matching has not been shown to produce many false positives, this should improve the situation somewhat.
Also removed the table in the comment as it is misleading when it comes to the intersection of the two sets. 1 ARP change and 1 matching entry does not mean that they are the same; it could be a coincidental update while the package was reinstalled at the same version.
Microsoft Reviewers: Open in CodeFlow