-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Managed Interop and merged manifest classes to WingetUtil nuget #1621
Introduce Managed Interop and merged manifest classes to WingetUtil nuget #1621
Conversation
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentactivatable Globals mytool URIs UtilsTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the [email protected]:jamespik/winget-cli-1.git repository
|
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentactivatable Globals mytool URIs UtilsTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the [email protected]:jamespik/winget-cli-1.git repository
|
azure-pipelines.nuget.yml
Outdated
|
||
# Run Interop Unit tests | ||
- task: VSTest@2 | ||
displayName: 'Run tests: WinGetUtilInterop.UnitTests' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests should be run as part of the primary PR pipeline, or the entire binary should be split into it's own solution with it's own pipeline. We don't run any of the tests here, it is just a pipeline to publish from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the test run to the primary pipeline. Need to validate this against the running pipeline though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you able to verify the .nuspec
builds appropriately?
This change wraps the existing winget util with a managed interop layer. A Target file is provided to automatically copy the wingetutil dlls to consuming project output directories.
We also add a set of managed merged manifest object files for manipulating merged manifest representations.
The build pipeline is updated to run the new tests, sign and include the new files.
Microsoft Reviewers: Open in CodeFlow