Added validation of count argument for search/list. #1564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1548, #1549.
This PR adds validation to the count argument for the
search
andlist
commands, throwing an exception if the value isn't between 1 and 1000 (or if it's out of bounds for an int, since that's whatstd::stoi
converts to). I figured that if the user could handle >1000 results, they could most likely handle all of them, although I can fix this in two seconds if that's too low.Please let me know if I put anything in the wrong place or if I did something wrong; this looked like an easy enough issue to tackle so I gave it a shot.
Tested manually (please let me know if I need to write unit tests).
Before:
After: