-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vsconfig file to automatically install required workloads. #1551
Conversation
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentBluetooth contosa contosainstaller convertto doctordns DSL etail globals IInstalled Jaifroid JDKs mikefrobbins mytool Nieto powershellexplained xboxTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the [email protected]:jedieaston/winget-cli.git repository
|
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentBluetooth contosa contosainstaller convertto doctordns DSL etail globals IInstalled Jaifroid JDKs mikefrobbins mytool Nieto powershellexplained xboxTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the [email protected]:jedieaston/winget-cli.git repository
|
@check-spelling-bot ReportUnrecognized words, please review:
To accept these unrecognized words as correct, run the following commands... in a clone of the [email protected]:jedieaston/winget-cli.git repository
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably have just excluded the .vsconfig from spell checking since it does not contain actual words for the most part. But thanks for the addition 👍
Something I noticed when trying to see if I could contribute anywhere in the project was that it's kind of hard to get all of the dependencies running in Visual Studio (at least, if you're like me and try to avoid VS like the plague).
This PR adds a .vsconfig file to the root of the repository, which causes Visual Studio 2019 to automatically prompt you when opening the repo to install any missing workloads (and automatically tells you which ones you need). I tried to keep it to the minimum required, but that's still quite a few things (.NET Desktop Development, C++ Development, UWP, the Spectre Mitigation libraries, Windows SDK 18362 and 19041, etc). You can't list extensions (so the Visual Studio Installer Projects extension still has to be installed manually), but this makes it a heck of a lot easier than going back to the installer every time the project won't build for something else.
I tested this in a VM and a sandbox, both worked great (i.e. the project built).
Microsoft Reviewers: Open in CodeFlow