Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable test hooks fixes #1501

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Disable test hooks fixes #1501

merged 2 commits into from
Sep 23, 2021

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Sep 23, 2021 •
edited by ghost
Loading

Change

Fixes to allow building with AICLI_DISABLE_TEST_HOOKS defined. Specifically:

  1. Exclude some function definitions whose declarations were already excluded.
  2. Refactor Context::ShouldExecuteWorkflowTask to not be virtual as any virtual function or member field being inside AICLI_DISABLE_TEST_HOOKS could lead to an ODR violation if not all projects properly apply it.
Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner September 23, 2021 04:29
yao-msft
yao-msft approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit 810a441 into microsoft:master Sep 23, 2021
@JohnMcPMS JohnMcPMS deleted the disabletesthooksfixes branch September 23, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnMcPMS @yao-msft