Support for x64 on ARM64 #1441
Merged
Support for x64 on ARM64 #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Issue-Feature
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Support for x64 emulation on ARM64 was added to Windows 10 Dev builds last year. In order for us to detect the presence of that support, a new API was needed.
Change
This change fixes #666 by implementing dynamic loading of the API and invoking it specifically for x64 when the machine is ARM64. The API can replace our current use of
IsWow64GuestMachineSupported, but there is no need to take the additional risk of that change at this time.Validation
As we do not have any automated test bed for ARM64, I was only able to test it manually on a local device.
Microsoft Reviewers: Open in CodeFlow