-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation of test_arch on arm64 #2978
Conversation
I found this while attempting to test all the -gnullvm arches, but it should also have failed to build for aarch64-pc-windows-msvc. |
There was no arm64 test, so this is less of a fix and more of an addition right? |
well, before
|
KNONVOLATILE_CONTEXT_POINTERS is not defined on arm64, it is called KNONVOLATILE_CONTEXT_POINTERS_ARM64 there instead. Add a test covering that on ARM64 too.
on aarch64-pc-windows-gnullvm, the following tests fail to build:
test_arch works after applying this PR, the others appear to fail simply because MSVC and/or Windows SDK are not installed on my arm64 machine. Everything else tested in test.yml succeeds. |
I was able to get |
Closing this in favor of #3000 where I've been able to get basic Arm64 compilation coverage working. |
KNONVOLATILE_CONTEXT_POINTERS
is not defined on arm64, it is calledKNONVOLATILE_CONTEXT_POINTERS_ARM64
there instead. Add a test covering that on ARM64 too.